When The Bills had really good teams in the early 90's, Buffalo was hemorrhaging population. I'm not sure there is any connection between a good local economy and whether a team is losing or winning. Dallas hasn't won a Super Bowl in almost 30 years, but that area is booming.A dome isn't as much of an issue as the location of the stadium. Putting it in an area that regularly gets hit by lake effect snow was short-sighted initially. Doing it again seems foolhardy, but it was the least expensive choice.
The Panthers haven't won much, but Charlotte has seen huge growth in the past 20 years.
The fragile psyche and obsession with the Bills is not healthy. Buffalo and the Niagara Falls region offer many other things. The new stadium deal is bad, no way to spin it. An open air stadium that will only be used maybe 15 times a year is an albatross...